Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift2objc] Visitor infra #1834

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[swift2objc] Visitor infra #1834

wants to merge 3 commits into from

Conversation

liamappelbe
Copy link
Contributor

This is the same infra as ffigen uses: #1638.

  • Copied the AstNode classes etc from ffigen
  • Made all the AST classes extends AstNode, and implemented the visit and visitChildren methods.
    • This meant that BuiltInDeclaration had to be converted from an enum to a class
  • Rewrote DependencyVisitor using the Visitation class

Ideally we'd share the AstNode, Visitor, and Visitation classes, but we don't really have a way of sharing internal code between native packages yet.

Part of #1358

@liamappelbe liamappelbe requested a review from dcharkes December 19, 2024 01:00
@coveralls
Copy link

coveralls commented Dec 19, 2024

Coverage Status

coverage: 87.67% (-0.3%) from 87.965%
when pulling ce1684b on swiftvisit2
into 8c16b6c on main.

@liamappelbe liamappelbe enabled auto-merge (squash) December 20, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants